c6x/timer64: Migrate to new 'set-state' interface
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 16 Jul 2015 11:26:17 +0000 (16:56 +0530)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Mon, 10 Aug 2015 09:41:00 +0000 (11:41 +0200)
Migrate c6x driver to the new 'set-state' interface provided by
clockevents core, the earlier 'set-mode' interface is marked obsolete
now.

This also enables us to implement callbacks for new states of clockevent
devices, for example: ONESHOT_STOPPED.

We weren't doing anything in ->set_mode(RESUME) and so tick_resume()
isn't implemented.

Cc: Mark Salter <msalter@redhat.com>
Cc: Aurelien Jacquiot <a-jacquiot@ti.com>
Cc: linux-c6x-dev@linux-c6x.org
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
arch/c6x/platforms/timer64.c

index 3c73d74a46742a5244a01ac320ac633bad769f50..c19901e5f05544997b87e961278d4ae6f525e2bf 100644 (file)
@@ -126,35 +126,37 @@ static int next_event(unsigned long delta,
        return 0;
 }
 
-static void set_clock_mode(enum clock_event_mode mode,
-                          struct clock_event_device *evt)
+static int set_periodic(struct clock_event_device *evt)
 {
-       switch (mode) {
-       case CLOCK_EVT_MODE_PERIODIC:
-               timer64_enable();
-               timer64_mode = TIMER64_MODE_PERIODIC;
-               timer64_config(TIMER64_RATE / HZ);
-               break;
-       case CLOCK_EVT_MODE_ONESHOT:
-               timer64_enable();
-               timer64_mode = TIMER64_MODE_ONE_SHOT;
-               break;
-       case CLOCK_EVT_MODE_UNUSED:
-       case CLOCK_EVT_MODE_SHUTDOWN:
-               timer64_mode = TIMER64_MODE_DISABLED;
-               timer64_disable();
-               break;
-       case CLOCK_EVT_MODE_RESUME:
-               break;
-       }
+       timer64_enable();
+       timer64_mode = TIMER64_MODE_PERIODIC;
+       timer64_config(TIMER64_RATE / HZ);
+       return 0;
+}
+
+static int set_oneshot(struct clock_event_device *evt)
+{
+       timer64_enable();
+       timer64_mode = TIMER64_MODE_ONE_SHOT;
+       return 0;
+}
+
+static int shutdown(struct clock_event_device *evt)
+{
+       timer64_mode = TIMER64_MODE_DISABLED;
+       timer64_disable();
+       return 0;
 }
 
 static struct clock_event_device t64_clockevent_device = {
-       .name           = "TIMER64_EVT32_TIMER",
-       .features       = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_PERIODIC,
-       .rating         = 200,
-       .set_mode       = set_clock_mode,
-       .set_next_event = next_event,
+       .name                   = "TIMER64_EVT32_TIMER",
+       .features               = CLOCK_EVT_FEAT_ONESHOT |
+                                 CLOCK_EVT_FEAT_PERIODIC,
+       .rating                 = 200,
+       .set_state_shutdown     = shutdown,
+       .set_state_periodic     = set_periodic,
+       .set_state_oneshot      = set_oneshot,
+       .set_next_event         = next_event,
 };
 
 static irqreturn_t timer_interrupt(int irq, void *dev_id)