staging: lustre: ptlrpc: set proper mbits for EINPROGRESS resend
authorNiu Yawei <yawei.niu@intel.com>
Sun, 29 Jan 2017 00:04:35 +0000 (19:04 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Feb 2017 12:01:37 +0000 (13:01 +0100)
Set mbits for EINPROGRESS resend in ptl_send_rpc().

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8193
Reviewed-on: http://review.whamcloud.com/20377
Reviewed-by: Liang Zhen <liang.zhen@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/ptlrpc/client.c
drivers/staging/lustre/lustre/ptlrpc/niobuf.c

index 44d8eab6f5af3907ac602cb61a1b521f89d3dd8a..a2a7b873698e7062a3fa28f02666b2bba4f94044 100644 (file)
@@ -3123,8 +3123,11 @@ void ptlrpc_set_bulk_mbits(struct ptlrpc_request *req)
                        req->rq_mbits = ptlrpc_next_xid();
                } else {
                        /* old version transfers rq_xid to peer as matchbits */
-                       req->rq_mbits = ptlrpc_next_xid();
-                       req->rq_xid = req->rq_mbits;
+                       spin_lock(&req->rq_import->imp_lock);
+                       list_del_init(&req->rq_unreplied_list);
+                       ptlrpc_assign_next_xid_nolock(req);
+                       req->rq_mbits = req->rq_xid;
+                       spin_unlock(&req->rq_import->imp_lock);
                }
 
                CDEBUG(D_HA, "resend bulk old x%llu new x%llu\n",
index da1209e40f03636763589d76c57baade1dd43cb8..b8701841ab4af55030d5a9d359d01400835ce668 100644 (file)
@@ -522,13 +522,14 @@ int ptl_send_rpc(struct ptlrpc_request *request, int noreply)
                 */
                spin_lock(&imp->imp_lock);
                ptlrpc_assign_next_xid_nolock(request);
-               request->rq_mbits = request->rq_xid;
                min_xid = ptlrpc_known_replied_xid(imp);
                spin_unlock(&imp->imp_lock);
 
                lustre_msg_set_last_xid(request->rq_reqmsg, min_xid);
                DEBUG_REQ(D_RPCTRACE, request, "Allocating new xid for resend on EINPROGRESS");
-       } else if (request->rq_bulk) {
+       }
+
+       if (request->rq_bulk) {
                ptlrpc_set_bulk_mbits(request);
                lustre_msg_set_mbits(request->rq_reqmsg, request->rq_mbits);
        }