net/wan/fsl_ucc_hdlc: fix unitialized variable warnings
authorHolger Brunck <holger.brunck@keymile.com>
Wed, 17 May 2017 15:24:33 +0000 (17:24 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 18 May 2017 14:28:38 +0000 (10:28 -0400)
This fixes the following compiler warnings:
drivers/net/wan/fsl_ucc_hdlc.c: In function 'ucc_hdlc_poll':
warning: 'skb' may be used uninitialized in this function
[-Wmaybe-uninitialized]
  skb->mac_header = skb->data - skb->head;

and

drivers/net/wan/fsl_ucc_hdlc.c: In function 'ucc_hdlc_probe':
drivers/net/wan/fsl_ucc_hdlc.c:1127:3: warning: 'utdm' may be used
uninitialized in this function [-Wmaybe-uninitialized]
   kfree(utdm);

Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Cc: Zhao Qiang <qiang.zhao@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/fsl_ucc_hdlc.c

index 0ae10a58ffca862910811c79a7c473c413fecae6..6ef6d719545d33f4184e8eb9e2e2422aa52aebe0 100644 (file)
@@ -440,7 +440,7 @@ static int hdlc_tx_done(struct ucc_hdlc_private *priv)
 static int hdlc_rx_done(struct ucc_hdlc_private *priv, int rx_work_limit)
 {
        struct net_device *dev = priv->ndev;
-       struct sk_buff *skb;
+       struct sk_buff *skb = NULL;
        hdlc_device *hdlc = dev_to_hdlc(dev);
        struct qe_bd *bd;
        u16 bd_status;
@@ -968,7 +968,7 @@ static int ucc_hdlc_probe(struct platform_device *pdev)
        struct device_node *np = pdev->dev.of_node;
        struct ucc_hdlc_private *uhdlc_priv = NULL;
        struct ucc_tdm_info *ut_info;
-       struct ucc_tdm *utdm;
+       struct ucc_tdm *utdm = NULL;
        struct resource res;
        struct net_device *dev;
        hdlc_device *hdlc;