x86: cpu/common*.c, merge early_identify_cpu()

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index ffc2f5ed09a3854335f1cdfefeee8ee3a93c95ea..61a70748213e687ee15de2d6c5186266852453e1 100644 (file)
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -490,7 +490,11 @@ static void __cpuinit get_cpu_cap(struct cpuinfo_x86 *c)
  */
 static void __init early_identify_cpu(struct cpuinfo_x86 *c)
 {
+#ifdef CONFIG_X86_64
+       c->x86_clflush_size = 64;
+#else
        c->x86_clflush_size = 32;
+#endif
        c->x86_cache_alignment = c->x86_clflush_size;
 
        if (!have_cpuid_p())

diff --git a/arch/x86/kernel/cpu/common_64.c b/arch/x86/kernel/cpu/common_64.c
index 75bb7ff99ee3f152a19b734351482e236d1f2649..6475548d64eb8498fd95a9bde00c1c4e91a2d4c2 100644 (file)
--- a/arch/x86/kernel/cpu/common_64.c
+++ b/arch/x86/kernel/cpu/common_64.c
@@ -482,15 +482,28 @@ static void __cpuinit get_cpu_cap(struct cpuinfo_x86 *c)
 #endif
 }
 
-/* Do some early cpuid on the boot CPU to get some parameter that are
-   needed before check_bugs. Everything advanced is in identify_cpu
-   below. */
+/*
+ * Do minimum CPU detection early.
+ * Fields really needed: vendor, cpuid_level, family, model, mask,
+ * cache alignment.
+ * The others are not touched to avoid unwanted side effects.
+ *
+ * WARNING: this function is only called on the BP.  Don't add code here
+ * that is supposed to run on all CPUs.
+ */
 static void __init early_identify_cpu(struct cpuinfo_x86 *c)
 {
 
+#ifdef CONFIG_X86_64
        c->x86_clflush_size = 64;
+#else
+       c->x86_clflush_size = 32;
+#endif
        c->x86_cache_alignment = c->x86_clflush_size;
 
+       if (!have_cpuid_p())
+               return;
+
        memset(&c->x86_capability, 0, sizeof c->x86_capability);
 
        c->extended_cpuid_level = 0;