drm/drm_stub: Remove unnecessary null check before kfree.
authorSachin Kamat <sachin.kamat@linaro.org>
Mon, 19 Nov 2012 09:44:59 +0000 (09:44 +0000)
committerDave Airlie <airlied@redhat.com>
Tue, 20 Nov 2012 05:41:00 +0000 (15:41 +1000)
kfree on a null argument is a no-op.
Silences the following smatch warning:
drivers/gpu/drm/drm_stub.c:496 drm_put_dev() info:
redundant null check on dev->devname calling kfree()

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/drm_stub.c

index 581e61d04057003049d3bdeecef8dca428f0a0a5..6fcdd8ebcb3d30ba66c151b30addc634970a48cd 100644 (file)
@@ -492,10 +492,7 @@ void drm_put_dev(struct drm_device *dev)
        drm_put_minor(&dev->primary);
 
        list_del(&dev->driver_item);
-       if (dev->devname) {
-               kfree(dev->devname);
-               dev->devname = NULL;
-       }
+       kfree(dev->devname);
        kfree(dev);
 }
 EXPORT_SYMBOL(drm_put_dev);