qed: Unlock on error in qed_vf_pf_acquire()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 28 Apr 2017 12:56:09 +0000 (15:56 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 1 May 2017 02:40:45 +0000 (22:40 -0400)
My static checker complains that we're holding a mutex on this error
path.  Let's goto exit instead of returning directly.

Fixes: b0bccb69eba3 ("qed: Change locking scheme for VF channel")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_vf.c

index c4c4a408b40bc8191aa99cfc7cb09df6dcef745f..11d71e5eea14375662e8e4da66a78e8b43d3f499 100644 (file)
@@ -234,7 +234,7 @@ static int qed_vf_pf_acquire(struct qed_hwfn *p_hwfn)
                /* send acquire request */
                rc = qed_send_msg2pf(p_hwfn, &resp->hdr.status, sizeof(*resp));
                if (rc)
-                       return rc;
+                       goto exit;
 
                /* copy acquire response from buffer to p_hwfn */
                memcpy(&p_iov->acquire_resp, resp, sizeof(p_iov->acquire_resp));