powerpc/nvram: Scan partitions only once
authorCedric Le Goater <clg@fr.ibm.com>
Wed, 30 Oct 2013 13:47:06 +0000 (14:47 +0100)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Thu, 31 Oct 2013 01:37:26 +0000 (12:37 +1100)
nvram_scan_partitions() is called twice when initializing the "lnx,oops-log"
partition and the "ibm,rtas-log" partition. This fills the partition list
with duplicate entries. This patch moves the partition scan in the init
routine pseries_nvram_init_log_partitions() which is called only once.

Signed-off-by: Cedric Le Goater <clg@fr.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/platforms/pseries/nvram.c

index d276cd3edd8f51641db54dfb459cb2efe4fa7f91..2498d4d801e8d0a6ca09c5875f9d20260a4cc2a6 100644 (file)
@@ -429,9 +429,6 @@ static int __init pseries_nvram_init_os_partition(struct nvram_os_partition
        loff_t p;
        int size;
 
-       /* Scan nvram for partitions */
-       nvram_scan_partitions();
-
        /* Look for ours */
        p = nvram_find_partition(part->name, NVRAM_SIG_OS, &size);
 
@@ -795,6 +792,9 @@ static int __init pseries_nvram_init_log_partitions(void)
 {
        int rc;
 
+       /* Scan nvram for partitions */
+       nvram_scan_partitions();
+
        rc = pseries_nvram_init_os_partition(&rtas_log_partition);
        nvram_init_oops_partition(rc == 0);
        return 0;