[media] fix coccinelle warnings
authorFengguang Wu <fengguang.wu@intel.com>
Fri, 20 Dec 2013 10:16:42 +0000 (07:16 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Tue, 7 Jan 2014 10:01:03 +0000 (08:01 -0200)
drivers/staging/media/bcm2048/radio-bcm2048.c:2632:1-7: Replace memcpy with struct assignment
/c/kernel-tests/src/cocci/drivers/staging/media/bcm2048/radio-bcm2048.c:744:1-7: Replace memcpy with struct assignment
/c/kernel-tests/src/cocci/drivers/staging/media/bcm2048/radio-bcm2048.c:2360:3-9: Replace memcpy with struct assignment

Generated by: coccinelle/misc/memcpy-assign.cocci

CC: Hans Verkuil <hans.verkuil@cisco.com>
CC: Mauro Carvalho Chehab <m.chehab@samsung.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/staging/media/bcm2048/radio-bcm2048.c

index 37ff89931ebc6fd43d98997bc851ca6d8ac1f0a8..9344daef4d644fab531c73b3751939239b05deb1 100644 (file)
@@ -741,8 +741,7 @@ static int bcm2048_set_region(struct bcm2048_device *bdev, u8 region)
                return -EINVAL;
 
        mutex_lock(&bdev->mutex);
-       memcpy(&bdev->region_info, &region_configs[region],
-               sizeof(struct region_info));
+       bdev->region_info = region_configs[region];
        mutex_unlock(&bdev->mutex);
 
        if (bdev->frequency < region_configs[region].bottom_frequency ||
@@ -2358,7 +2357,7 @@ static int bcm2048_vidioc_queryctrl(struct file *file, void *priv,
 
        for (i = 0; i < ARRAY_SIZE(bcm2048_v4l2_queryctrl); i++) {
                if (qc->id && qc->id == bcm2048_v4l2_queryctrl[i].id) {
-                       memcpy(qc, &(bcm2048_v4l2_queryctrl[i]), sizeof(*qc));
+                       *qc = bcm2048_v4l2_queryctrl[i];
                        return 0;
                }
        }
@@ -2630,8 +2629,7 @@ static int bcm2048_i2c_driver_probe(struct i2c_client *client,
                dev_dbg(&client->dev, "IRQ not configured. Using timeouts.\n");
        }
 
-       memcpy(bdev->videodev, &bcm2048_viddev_template,
-                       sizeof(bcm2048_viddev_template));
+       *bdev->videodev = bcm2048_viddev_template;
        video_set_drvdata(bdev->videodev, bdev);
        if (video_register_device(bdev->videodev, VFL_TYPE_RADIO, radio_nr)) {
                dev_dbg(&client->dev, "Could not register video device.\n");