drm/i915: add DP support to intel_enable_ddi
authorPaulo Zanoni <paulo.r.zanoni@intel.com>
Mon, 15 Oct 2012 18:51:40 +0000 (15:51 -0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 18 Oct 2012 18:43:44 +0000 (20:43 +0200)
We should only write the DDI_BUF_CTL at this point for HDMI/DVI. For
DP we need to do this earlier, and the values written to the register
are also different.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_ddi.c

index 197ea9abf66f7740c1f3cf77385858b9b76ba07a..aabbeb850ac748460c1c72d394f903799d98a444 100644 (file)
@@ -1122,18 +1122,21 @@ void intel_ddi_post_disable(struct intel_encoder *intel_encoder)
        I915_WRITE(PORT_CLK_SEL(port), PORT_CLK_SEL_NONE);
 }
 
-void intel_enable_ddi(struct intel_encoder *encoder)
+void intel_enable_ddi(struct intel_encoder *intel_encoder)
 {
-       struct drm_device *dev = encoder->base.dev;
+       struct drm_encoder *encoder = &intel_encoder->base;
+       struct drm_device *dev = encoder->dev;
        struct drm_i915_private *dev_priv = dev->dev_private;
-       struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(&encoder->base);
-       int port = intel_hdmi->ddi_port;
+       enum port port = intel_ddi_get_encoder_port(intel_encoder);
+       int type = intel_encoder->type;
 
-       /* Enable DDI_BUF_CTL. In HDMI/DVI mode, the port width,
-        * and swing/emphasis values are ignored so nothing special needs
-        * to be done besides enabling the port.
-        */
-       I915_WRITE(DDI_BUF_CTL(port), DDI_BUF_CTL_ENABLE);
+       if (type == INTEL_OUTPUT_HDMI) {
+               /* In HDMI/DVI mode, the port width, and swing/emphasis values
+                * are ignored so nothing special needs to be done besides
+                * enabling the port.
+                */
+               I915_WRITE(DDI_BUF_CTL(port), DDI_BUF_CTL_ENABLE);
+       }
 }
 
 void intel_disable_ddi(struct intel_encoder *encoder)