IB/mad: Fix RMPP version check during agent registration
authorHal Rosenstock <halr@voltaire.com>
Thu, 13 Apr 2006 01:29:10 +0000 (21:29 -0400)
committerRoland Dreier <rolandd@cisco.com>
Wed, 19 Apr 2006 18:40:11 +0000 (11:40 -0700)
Only check that RMPP version is not specified when MAD class does not
support RMPP.  Just because a class is allowed to use RMPP doesn't
mean that rmpp_version needs to be set for the MAD agent to
register. Checking this was a recent change which was too pedantic.

Signed-off-by: Hal Rosenstock <halr@voltaire.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/core/mad.c

index 3a702da83e41bc595263aa29438fadc0ed3df3d3..469b6923a2e2e0a2c59b388d8f93fedc2e961fac 100644 (file)
@@ -228,10 +228,7 @@ struct ib_mad_agent *ib_register_mad_agent(struct ib_device *device,
                                goto error1;
                }
                /* Make sure class supplied is consistent with RMPP */
-               if (ib_is_mad_class_rmpp(mad_reg_req->mgmt_class)) {
-                       if (!rmpp_version)
-                               goto error1;
-               } else {
+               if (!ib_is_mad_class_rmpp(mad_reg_req->mgmt_class)) {
                        if (rmpp_version)
                                goto error1;
                }