IB/hfi1: use size_t for passing array length
authorArnd Bergmann <arnd@arndb.de>
Tue, 14 Feb 2017 21:23:07 +0000 (22:23 +0100)
committerDoug Ledford <dledford@redhat.com>
Sun, 19 Feb 2017 14:18:47 +0000 (09:18 -0500)
gcc-7 produces a mysterious warning about the size argument being potentially out
of range:

drivers/infiniband/hw/hfi1/verbs.c: In function 'init_cntr_names':
drivers/infiniband/hw/hfi1/verbs.c:1644:2: error: 'memcpy': specified size between 18446744071562067968 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]

This seems to refer to a the case where an 64-bit size_t gets truncated
into a negative 'int' and subsequently turned into a high 64-bit number
again.

The fix is clearly to use size_t here, which matches the type that gets
used for this value elsewhere.

Fixes: b7481944b06e ("IB/hfi1: Show statistics counters under IB stats interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/hfi1/verbs.c

index 72f459e1fdde39edac5532bf19dd2d8196da5d06..5ba4c0dec3488429de0a6a0d83fc9f89e9a8b17d 100644 (file)
@@ -1536,7 +1536,7 @@ static int cntr_names_initialized;
  * external strings.
  */
 static int init_cntr_names(const char *names_in,
-                          const int names_len,
+                          const size_t names_len,
                           int num_extra_names,
                           int *num_cntrs,
                           const char ***cntr_names)