PCI: Don't pass pci_dev to pci_ext_cfg_avail()
authorTaku Izumi <izumi.taku@jp.fujitsu.com>
Tue, 30 Oct 2012 06:26:18 +0000 (15:26 +0900)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 7 Nov 2012 16:43:28 +0000 (09:43 -0700)
pci_ext_cfg_avail() doesn't use the "struct pci_dev *" passed to
it, and there's no requirement that a host bridge even be represented
by a pci_dev.  This drops the pci_ext_cfg_avail() parameter.

[bhelgaas: changelog]
Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
arch/x86/pci/common.c
drivers/acpi/pci_root.c
drivers/pci/pci.c
include/linux/pci.h

index 720e973fc34a31b856998715165f7fc50ec9ec6d..52dbf1aeeb63fe3099c0c2a8c4ca8e92dcd3d952 100644 (file)
@@ -626,7 +626,7 @@ void pcibios_disable_device (struct pci_dev *dev)
                pcibios_disable_irq(dev);
 }
 
-int pci_ext_cfg_avail(struct pci_dev *dev)
+int pci_ext_cfg_avail(void)
 {
        if (raw_pci_ext_ops)
                return 1;
index 66f3ae74d13001c1fca65d7083e2bc83bc3b8b3d..50f329d7ccff087185295b9b0c4815d62bc2e96b 100644 (file)
@@ -564,7 +564,7 @@ static int __devinit acpi_pci_root_add(struct acpi_device *device)
                acpi_pci_bridge_scan(child);
 
        /* Indicate support for various _OSC capabilities. */
-       if (pci_ext_cfg_avail(root->bus->self))
+       if (pci_ext_cfg_avail())
                flags |= OSC_EXT_PCI_CONFIG_SUPPORT;
        if (pcie_aspm_support_enabled())
                flags |= OSC_ACTIVE_STATE_PWR_SUPPORT |
index 54858838f09867f142886edcac6b4dab9c049531..01b68bfa2321c2fc003d1e3e02f08c48ad0dab64 100644 (file)
@@ -3833,14 +3833,13 @@ static void __devinit pci_no_domains(void)
 }
 
 /**
- * pci_ext_cfg_enabled - can we access extended PCI config space?
- * @dev: The PCI device of the root bridge.
+ * pci_ext_cfg_avail - can we access extended PCI config space?
  *
  * Returns 1 if we can access PCI extended config space (offsets
  * greater than 0xff). This is the default implementation. Architecture
  * implementations can override this.
  */
-int __weak pci_ext_cfg_avail(struct pci_dev *dev)
+int __weak pci_ext_cfg_avail(void)
 {
        return 1;
 }
index 786094254d573986b42d21b1f7e659a10b8e7e55..9253af697ca4ac4ff03fe4dbb6d125d24e2eca7e 100644 (file)
@@ -1604,7 +1604,7 @@ static inline void pci_mmcfg_early_init(void) { }
 static inline void pci_mmcfg_late_init(void) { }
 #endif
 
-int pci_ext_cfg_avail(struct pci_dev *dev);
+int pci_ext_cfg_avail(void);
 
 void __iomem *pci_ioremap_bar(struct pci_dev *pdev, int bar);