drm/cirrus: Delete an unnecessary check before drm_gem_object_unreference_unlocked()
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 16 Jul 2016 06:28:13 +0000 (08:28 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 18 Jul 2016 07:11:30 +0000 (09:11 +0200)
The drm_gem_object_unreference_unlocked() function tests whether
its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/bebf88d8-cc28-657a-e96c-58447d8cf376@users.sourceforge.net
drivers/gpu/drm/cirrus/cirrus_main.c

index 32d32c5b7b17448bdb252301d5cea65f3e3cacbf..80446e2d3ab6efd00f3d3e777e4178b26ee6ae5d 100644 (file)
@@ -17,8 +17,8 @@
 static void cirrus_user_framebuffer_destroy(struct drm_framebuffer *fb)
 {
        struct cirrus_framebuffer *cirrus_fb = to_cirrus_framebuffer(fb);
-       if (cirrus_fb->obj)
-               drm_gem_object_unreference_unlocked(cirrus_fb->obj);
+
+       drm_gem_object_unreference_unlocked(cirrus_fb->obj);
        drm_framebuffer_cleanup(fb);
        kfree(fb);
 }