ACPI / scan: Allow platform device creation without any IO resources
authorKuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Mon, 22 Jul 2013 23:51:20 +0000 (16:51 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 6 Aug 2013 12:12:21 +0000 (14:12 +0200)
Currently, ACPI platform device creation is aborted when there
are no valid IO resources for the device.  This approach will not
work if the device has only GPIO as its resource or some custom
resources.

Remove zero resource check and allow platform device creation even
without any valid IO resources.

[rjw: Changelog]
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/acpi_platform.c

index fafec5ddf17f17c326181988cf3f7d3d625c442f..32136b85196d438e665b27bb7e5686e3e1fa243f 100644 (file)
@@ -52,7 +52,7 @@ int acpi_create_platform_device(struct acpi_device *adev,
        struct platform_device_info pdevinfo;
        struct resource_list_entry *rentry;
        struct list_head resource_list;
-       struct resource *resources;
+       struct resource *resources = NULL;
        int count;
 
        /* If the ACPI node already has a physical device attached, skip it. */
@@ -61,9 +61,12 @@ int acpi_create_platform_device(struct acpi_device *adev,
 
        INIT_LIST_HEAD(&resource_list);
        count = acpi_dev_get_resources(adev, &resource_list, NULL, NULL);
-       if (count <= 0)
+       if (count < 0)
                return 0;
 
+       if (!count)
+               goto create_dev;
+
        resources = kmalloc(count * sizeof(struct resource), GFP_KERNEL);
        if (!resources) {
                dev_err(&adev->dev, "No memory for resources\n");
@@ -76,6 +79,7 @@ int acpi_create_platform_device(struct acpi_device *adev,
 
        acpi_dev_free_resource_list(&resource_list);
 
+create_dev:
        memset(&pdevinfo, 0, sizeof(pdevinfo));
        /*
         * If the ACPI node has a parent and that parent has a physical device