ARM: bcm: Fix refcount leak in bcm_kona_smc_init
authorMiaoqian Lin <linmq006@gmail.com>
Thu, 26 May 2022 08:13:25 +0000 (12:13 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:11:15 +0000 (11:11 +0200)
[ Upstream commit cb23389a2458c2e4bfd6c86a513cbbe1c4d35e76 ]

of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: b8eb35fd594a ("ARM: bcm281xx: Add L2 cache enable code")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/mach-bcm/bcm_kona_smc.c

index a55a7ecf146a277df8c55603837b67d6fdc30a03..dd0b4195e629cc26e6220494df0e6a6ae776d5cd 100644 (file)
@@ -54,6 +54,7 @@ int __init bcm_kona_smc_init(void)
                return -ENODEV;
 
        prop_val = of_get_address(node, 0, &prop_size, NULL);
+       of_node_put(node);
        if (!prop_val)
                return -EINVAL;