Make SessionHandler::createLegacySession() return the session

This does not implicitly modify class properties and thus makes the code
cleaner.

diff --git a/wcfsetup/install/files/lib/system/session/SessionHandler.class.php b/wcfsetup/install/files/lib/system/session/SessionHandler.class.php
index 10522693f296566a7c65c56e384ac298829131e8..ee482a15797d2432142a41b4054d8d3ee481081b 100644 (file)
--- a/wcfsetup/install/files/lib/system/session/SessionHandler.class.php
+++ b/wcfsetup/install/files/lib/system/session/SessionHandler.class.php
@@ -659,7 +659,7 @@ final class SessionHandler extends SingletonFactory
         $this->legacySession = $statement->fetchSingleObject(LegacySession::class);
 
         if (!$this->legacySession) {
-            $this->createLegacySession();
+            $this->legacySession = $this->createLegacySession();
         }
 
         return true;
@@ -717,11 +717,11 @@ final class SessionHandler extends SingletonFactory
         }
 
         if (!$this->legacySession) {
-            $this->createLegacySession();
+            $this->legacySession = $this->createLegacySession();
         }
     }
 
-    private function createLegacySession()
+    private function createLegacySession(): LegacySession
     {
         $spiderID = $this->getSpiderID(UserUtil::getUserAgent());
 
@@ -737,7 +737,7 @@ final class SessionHandler extends SingletonFactory
             'spiderID' => $spiderID,
         ];
 
-        $this->legacySession = SessionEditor::create($sessionData);
+        return SessionEditor::create($sessionData);
     }
 
     /**