ALSA: compress: fix an integer overflow check
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 16 Jul 2014 06:37:04 +0000 (09:37 +0300)
committerTakashi Iwai <tiwai@suse.de>
Wed, 16 Jul 2014 13:27:03 +0000 (15:27 +0200)
I previously added an integer overflow check here but looking at it now,
it's still buggy.

The bug happens in snd_compr_allocate_buffer().  We multiply
".fragments" and ".fragment_size" and that doesn't overflow but then we
save it in an unsigned int so it truncates the high bits away and we
allocate a smaller than expected size.

Fixes: b35cc8225845 ('ALSA: compress_core: integer overflow in snd_compr_allocate_buffer()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/compress_offload.c

index 7403f348ed1425733ce77735c8dff37d1610ad4d..89028fab64fdd27bd75698e651fdc3b26b424941 100644 (file)
@@ -491,7 +491,7 @@ static int snd_compress_check_input(struct snd_compr_params *params)
 {
        /* first let's check the buffer parameter's */
        if (params->buffer.fragment_size == 0 ||
-                       params->buffer.fragments > SIZE_MAX / params->buffer.fragment_size)
+           params->buffer.fragments > INT_MAX / params->buffer.fragment_size)
                return -EINVAL;
 
        /* now codec parameters */