x86: apic: Check rev 3 fadt correctly for physical_apic bit
authorYinghai Lu <yinghai@kernel.org>
Sun, 10 May 2009 06:47:42 +0000 (23:47 -0700)
committerIngo Molnar <mingo@elte.hu>
Mon, 11 May 2009 08:52:40 +0000 (10:52 +0200)
Impact: fix fadt version checking

FADT2_REVISION_ID has value 3 aka rev 3 FADT. So need to use >= instead
of >, as other places in the code do.

[ Impact: extend scope of APIC boot quirk ]

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/apic/apic_flat_64.c

index 306e5e88fb6f4abc9a53a3ce8638ac904a67067e..744e6d8af27b8e091bedb5c92bac1bec344395f6 100644 (file)
@@ -235,7 +235,7 @@ static int physflat_acpi_madt_oem_check(char *oem_id, char *oem_table_id)
         * regardless of how many processors are present (x86_64 ES7000
         * is an example).
         */
-       if (acpi_gbl_FADT.header.revision > FADT2_REVISION_ID &&
+       if (acpi_gbl_FADT.header.revision >= FADT2_REVISION_ID &&
                (acpi_gbl_FADT.flags & ACPI_FADT_APIC_PHYSICAL)) {
                printk(KERN_DEBUG "system APIC only can use physical flat");
                return 1;