staging/lustre/obdecho: Remove always true condition
authorOleg Drokin <green@linuxhacker.ru>
Wed, 10 Feb 2016 18:00:18 +0000 (13:00 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 12 Feb 2016 03:29:55 +0000 (19:29 -0800)
Dan Carpenter noticed that since we already checked for
(oa->o_valid & OBD_MD_FLID) == 0, that means
(oa->o_valid & OBD_MD_FLID) is always true after that so
no point in checking for it.

Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/obdecho/echo_client.c

index d3e398f70434bb24d0a5f26e89f5277c797747f2..e1c9d118e037c90b13233e4f6ae610c2ade2da7c 100644 (file)
@@ -1222,10 +1222,8 @@ static int echo_create_object(const struct lu_env *env, struct echo_device *ed,
        }
 
        /* setup object ID here */
-       if (oa->o_valid & OBD_MD_FLID) {
-               LASSERT(oa->o_valid & OBD_MD_FLGROUP);
-               lsm->lsm_oi = oa->o_oi;
-       }
+       LASSERT(oa->o_valid & OBD_MD_FLGROUP);
+       lsm->lsm_oi = oa->o_oi;
 
        if (ostid_id(&lsm->lsm_oi) == 0)
                ostid_set_id(&lsm->lsm_oi, ++last_object_id);