Input: ar1021_i2c - do not force raising edge IRQ trigger
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 13 Apr 2017 23:36:42 +0000 (16:36 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 14 Apr 2017 17:16:50 +0000 (10:16 -0700)
We should not be forcing edge triggered interrupt, but rather let platform
decide the kind of trigger it needs to use. Also, the driver is not quite
safe with regard to edge-triggered interrupts as it does not try to kick
the controller after requesting/enabling IRQ.

Reviewed-By: Christian Gmeiner <christian.gmeiner@gmail.com>
Tested-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/ar1021_i2c.c

index 6797e123925a35a0c43ee2996794d1fd759af9aa..6c3c79b7ff5196746a6a3f3cd07c3733ee6449cf 100644 (file)
@@ -109,7 +109,7 @@ static int ar1021_i2c_probe(struct i2c_client *client,
 
        error = devm_request_threaded_irq(&client->dev, client->irq,
                                          NULL, ar1021_i2c_irq,
-                                         IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+                                         IRQF_ONESHOT,
                                          "ar1021_i2c", ar1021);
        if (error) {
                dev_err(&client->dev,