staging: comedi: addi_apci_3501: remove use of comedi_error()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Thu, 17 Jul 2014 18:57:52 +0000 (11:57 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Jul 2014 00:59:03 +0000 (17:59 -0700)
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
characters.

Use dev_err() directly instead of comedi_error() to avoid any confusion
and so that all the comedi generated kernel messages have the same format.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/addi_apci_3501.c

index 49bf1fb840f62ab3f35dd7d66173078065bbadb0..d9594f48d00f220a9851f50c10915a8eebafea00 100644 (file)
@@ -274,7 +274,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
 
        ui_Timer_AOWatchdog = inl(dev->iobase + APCI3501_TIMER_IRQ_REG) & 0x1;
        if ((!ui_Timer_AOWatchdog)) {
-               comedi_error(dev, "IRQ from unknown source");
+               dev_err(dev->class_dev, "IRQ from unknown source\n");
                return IRQ_NONE;
        }