staging: comedi: addi_apci_2032: cleanup the s->subdev_flags
authorH Hartley Sweeten <hartleys@visionengravers.com>
Fri, 30 Nov 2012 01:18:35 +0000 (18:18 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 30 Nov 2012 02:05:30 +0000 (18:05 -0800)
The flags SDF_GROUND and SDF_COMMON only have meaning for analog
input/output subdevices. Remove these flags from the digital
output and timer subdevices in this driver.

The digital output subdevice does not need the SDF_READABLE flag.
Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/addi_apci_2032.c

index 93ff8300fed8a213fdaaa72b8e0bfbfb75d774cd..26f6e0072ed03b2adf2a2b169d08e0143aee2163 100644 (file)
@@ -59,8 +59,7 @@ static int apci2032_auto_attach(struct comedi_device *dev,
        /* Initialize the digital output subdevice */
        s = &dev->subdevices[0];
        s->type = COMEDI_SUBD_DO;
-       s->subdev_flags =
-               SDF_READABLE | SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
+       s->subdev_flags = SDF_WRITEABLE;
        s->n_chan = 32;
        s->maxdata = 1;
        s->range_table = &range_digital;
@@ -71,7 +70,7 @@ static int apci2032_auto_attach(struct comedi_device *dev,
        /* Initialize the watchdog subdevice */
        s = &dev->subdevices[1];
        s->type = COMEDI_SUBD_TIMER;
-       s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
+       s->subdev_flags = SDF_WRITEABLE;
        s->n_chan = 1;
        s->maxdata = 0;
        s->len_chanlist = 1;