sunrpc: Don't do a dst_confirm() on an input routes.

xs_udp_data_ready() is operating on received packets, and tries to
do a dst_confirm() on the dst attached to the SKB.

This isn't right, dst confirmation is for output routes, not input
rights.  It's for resetting the timers on the nexthop neighbour entry
for the route, indicating that we've got good evidence that we've
successfully reached it.

Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 890b03f8d8771ea325cf41be4f9bddd50a07fc12..62d0dac8f7807f9fbfbe3fbc10315e5386197b89 100644 (file)
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -1014,9 +1014,6 @@ static void xs_udp_data_ready(struct sock *sk, int len)
 
        UDPX_INC_STATS_BH(sk, UDP_MIB_INDATAGRAMS);
 
-       /* Something worked... */
-       dst_confirm(skb_dst(skb));
-
        xprt_adjust_cwnd(task, copied);
        xprt_complete_rqst(task, copied);