BUG_ON() Conversion in drivers/s390/block/dasd_devmap.c
authorEric Sesterhenn <snakebyte@gmx.de>
Sun, 26 Mar 2006 16:33:07 +0000 (18:33 +0200)
committerAdrian Bunk <bunk@stusta.de>
Sun, 26 Mar 2006 16:33:07 +0000 (18:33 +0200)
this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
drivers/s390/block/dasd_devmap.c

index 2f720108a7e07da24632a68fe3d6ac88a0773139..c1c6f138115002d3f7fb0f5606e7ecec691c9be9 100644 (file)
@@ -437,8 +437,7 @@ dasd_forget_ranges(void)
        spin_lock(&dasd_devmap_lock);
        for (i = 0; i < 256; i++) {
                list_for_each_entry_safe(devmap, n, &dasd_hashlists[i], list) {
-                       if (devmap->device != NULL)
-                               BUG();
+                       BUG_ON(devmap->device != NULL);
                        list_del(&devmap->list);
                        kfree(devmap);
                }
@@ -547,8 +546,7 @@ dasd_delete_device(struct dasd_device *device)
 
        /* First remove device pointer from devmap. */
        devmap = dasd_find_busid(device->cdev->dev.bus_id);
-       if (IS_ERR(devmap))
-               BUG();
+       BUG_ON(IS_ERR(devmap));
        spin_lock(&dasd_devmap_lock);
        if (devmap->device != device) {
                spin_unlock(&dasd_devmap_lock);