sfc: Fix TX queue numbering when separate_tx_channels=1
authorBen Hutchings <bhutchings@solarflare.com>
Mon, 16 May 2011 16:32:39 +0000 (17:32 +0100)
committerBen Hutchings <bhutchings@solarflare.com>
Mon, 16 May 2011 16:35:19 +0000 (17:35 +0100)
This option appears to have been broken by commit
8313aca38b3937947fffebca6e34bac8e24300c8 ('sfc: Allocate each channel
separately, along with its RX and TX queues').

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
drivers/net/sfc/efx.c

index 38a55e9e89e424a9cd233d2cf13357074de65337..796c47e03f65e08aa5bf95de53804b2a362aa3fc 100644 (file)
@@ -1319,8 +1319,20 @@ static void efx_remove_interrupts(struct efx_nic *efx)
 
 static void efx_set_channels(struct efx_nic *efx)
 {
+       struct efx_channel *channel;
+       struct efx_tx_queue *tx_queue;
+
        efx->tx_channel_offset =
                separate_tx_channels ? efx->n_channels - efx->n_tx_channels : 0;
+
+       /* We need to adjust the TX queue numbers if we have separate
+        * RX-only and TX-only channels.
+        */
+       efx_for_each_channel(channel, efx) {
+               efx_for_each_channel_tx_queue(tx_queue, channel)
+                       tx_queue->queue -= (efx->tx_channel_offset *
+                                           EFX_TXQ_TYPES);
+       }
 }
 
 static int efx_probe_nic(struct efx_nic *efx)