Staging: dream: fix dangling i2c pointers
authorWolfram Sang <w.sang@pengutronix.de>
Sat, 20 Mar 2010 14:13:00 +0000 (15:13 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 11 May 2010 18:35:45 +0000 (11:35 -0700)
Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/dream/synaptics_i2c_rmi.c

index d2ca116a1c256beafc955db859175d984f62a740..ae2f72ca7351da635a3ed54834b8b384fa644d71 100644 (file)
@@ -535,6 +535,7 @@ err_input_register_device_failed:
 err_input_dev_alloc_failed:
 err_detect_failed:
 err_power_failed:
+       i2c_set_clientdata(client, NULL);
        kfree(ts);
 err_alloc_data_failed:
 err_check_functionality_failed:
@@ -552,6 +553,7 @@ static int synaptics_ts_remove(struct i2c_client *client)
        else
                hrtimer_cancel(&ts->timer);
        input_unregister_device(ts->input_dev);
+       i2c_set_clientdata(client, NULL);
        kfree(ts);
        return 0;
 }