SUNRPC: Address kbuild warning in net/sunrpc/debugfs.c
authorChuck Lever <chuck.lever@oracle.com>
Thu, 11 Jun 2015 17:47:10 +0000 (13:47 -0400)
committerTrond Myklebust <trond.myklebust@primarydata.com>
Thu, 11 Jun 2015 18:01:06 +0000 (14:01 -0400)
Cross-compile test on ARCH=mn10300:

In file included from include/linux/list.h:8:0,
                 from include/linux/wait.h:6,
                 from include/linux/fs.h:6,
                 from include/linux/debugfs.h:18,
                 from net/sunrpc/debugfs.c:7:
net/sunrpc/debugfs.c: In function 'fault_disconnect_write':
include/linux/kernel.h:723:17: warning: comparison of distinct pointer
types lacks a cast
    (void) (&_min1 == &_min2);  \
                   ^
>> net/sunrpc/debugfs.c:307:8: note: in expansion of macro 'min'
    len = min(len, sizeof(buffer) - 1);

Fixes: ('SUNRPC: Transport fault injection')
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
net/sunrpc/debugfs.c

index 7cc1b8a6ef6d54e2c8cdb7737310ba7a4b0ce73d..e7b4d93566df42dfa5ecf985152235e539ed9933 100644 (file)
@@ -304,7 +304,8 @@ fault_disconnect_write(struct file *filp, const char __user *user_buf,
 {
        char buffer[16];
 
-       len = min(len, sizeof(buffer) - 1);
+       if (len >= sizeof(buffer))
+               len = sizeof(buffer) - 1;
        if (copy_from_user(buffer, user_buf, len))
                return -EFAULT;
        buffer[len] = '\0';