intel_pstate: Fix MSR_CONFIG_TDP_x addressing in core_get_max_pstate()
authorJan Kiszka <jan.kiszka@siemens.com>
Fri, 8 Jul 2016 18:42:04 +0000 (20:42 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 11 Jul 2016 13:12:30 +0000 (15:12 +0200)
If MSR_CONFIG_TDP_CONTROL is locked, we currently try to address some
MSR 0x80000648 or so. Mask out the relevant level bits 0 and 1.

Found while running over the Jailhouse hypervisor which became upset
about this strange MSR index.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: 4.4+ <stable@vger.kernel.org> # 4.4+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/intel_pstate.c

index f6dd07275862faff1a76b3c0d28aff6e748a6729..25bfdec4e74ee15fae69fa12f831509513f9d996 100644 (file)
@@ -945,7 +945,7 @@ static int core_get_max_pstate(void)
                        if (err)
                                goto skip_tar;
 
-                       tdp_msr = MSR_CONFIG_TDP_NOMINAL + tdp_ctrl;
+                       tdp_msr = MSR_CONFIG_TDP_NOMINAL + (tdp_ctrl & 0x3);
                        err = rdmsrl_safe(tdp_msr, &tdp_ratio);
                        if (err)
                                goto skip_tar;