bonding: Improve syslog message at device creation time
authorPhil Oester <kernel@linuxace.com>
Mon, 14 Mar 2011 06:22:06 +0000 (06:22 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 Mar 2011 02:29:39 +0000 (19:29 -0700)
When the bonding module is loaded, it creates bond0 by default.
Then, when attempting to create bond0, the following messages
are printed to syslog:

    kernel: bonding: bond0 is being created...
    kernel: bonding: Bond creation failed.

Which seems to indicate a problem, when in reality there is no
problem.  Since the actual error code is passed down from bond_create,
make use of it to print a bit less ominous message:

    kernel: bonding: bond0 is being created...
    kernel: bond0 already exists.

Signed-off-by: Phil Oester <kernel@linuxace.com>
Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_sysfs.c

index 72bb0f6cc9bf39289ec7b9c0185f9d3ded6a4af8..e718144c5cfa774a6777e1540c608a36bac1d813 100644 (file)
@@ -118,7 +118,10 @@ static ssize_t bonding_store_bonds(struct class *cls,
                pr_info("%s is being created...\n", ifname);
                rv = bond_create(net, ifname);
                if (rv) {
-                       pr_info("Bond creation failed.\n");
+                       if (rv == -EEXIST)
+                               pr_info("%s already exists.\n", ifname);
+                       else
+                               pr_info("%s creation failed.\n", ifname);
                        res = rv;
                }
        } else if (command[0] == '-') {