drm/exynos: use ERR_PTR instead of NULL in exynos_drm_gem_init
authorJoonyoung Shim <jy0922.shim@samsung.com>
Tue, 28 Jul 2015 08:53:22 +0000 (17:53 +0900)
committerInki Dae <inki.dae@samsung.com>
Sun, 16 Aug 2015 04:35:13 +0000 (13:35 +0900)
For more correct error information.

Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_drm_gem.c

index fa04b9add09aaf79cbb5e8c1c945adbe4b2c40b0..d7a687bd0006870b41f54e4c6f19e965d352eb43 100644 (file)
@@ -139,7 +139,7 @@ struct exynos_drm_gem_obj *exynos_drm_gem_init(struct drm_device *dev,
 
        exynos_gem_obj = kzalloc(sizeof(*exynos_gem_obj), GFP_KERNEL);
        if (!exynos_gem_obj)
-               return NULL;
+               return ERR_PTR(-ENOMEM);
 
        exynos_gem_obj->size = size;
        obj = &exynos_gem_obj->base;
@@ -148,7 +148,7 @@ struct exynos_drm_gem_obj *exynos_drm_gem_init(struct drm_device *dev,
        if (ret < 0) {
                DRM_ERROR("failed to initialize gem object\n");
                kfree(exynos_gem_obj);
-               return NULL;
+               return ERR_PTR(ret);
        }
 
        DRM_DEBUG_KMS("created file object = 0x%x\n", (unsigned int)obj->filp);
@@ -180,8 +180,8 @@ struct exynos_drm_gem_obj *exynos_drm_gem_create(struct drm_device *dev,
                return ERR_PTR(-ENOMEM);
 
        exynos_gem_obj = exynos_drm_gem_init(dev, size);
-       if (!exynos_gem_obj) {
-               ret = -ENOMEM;
+       if (IS_ERR(exynos_gem_obj)) {
+               ret = PTR_ERR(exynos_gem_obj);
                goto err_fini_buf;
        }