staging: unisys: visorbus: remove controlvm_respond_chipset_init prototype
authorDavid Kershner <david.kershner@unisys.com>
Mon, 19 Sep 2016 21:09:26 +0000 (17:09 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Sep 2016 11:26:21 +0000 (13:26 +0200)
Remove the unneeded controlvm_respond_chipset_init prototype by
moving the functions controlvm_init_response and
controlvm_respond_chipset_init up in the file.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/visorchipset.c

index 6f530ea4c59ad360fa0dc3c717fbdf29fd7e6714..7dcf0b3a1017c9b472974e25f54821d72e3453c6 100644 (file)
@@ -271,9 +271,6 @@ static struct platform_device visorchipset_platform_device = {
 };
 
 /* Function prototypes */
-static void controlvm_respond_chipset_init(
-               struct controlvm_message_header *msg_hdr, int response,
-               enum ultra_chipset_feature features);
 static void controlvm_respond_physdev_changestate(
                struct controlvm_message_header *msg_hdr, int response,
                struct spar_segment_state state);
@@ -637,6 +634,36 @@ struct visor_device *visorbus_get_device_by_id(u32 bus_no, u32 dev_no,
        return vdev;
 }
 
+static void
+controlvm_init_response(struct controlvm_message *msg,
+                       struct controlvm_message_header *msg_hdr, int response)
+{
+       memset(msg, 0, sizeof(struct controlvm_message));
+       memcpy(&msg->hdr, msg_hdr, sizeof(struct controlvm_message_header));
+       msg->hdr.payload_bytes = 0;
+       msg->hdr.payload_vm_offset = 0;
+       msg->hdr.payload_max_bytes = 0;
+       if (response < 0) {
+               msg->hdr.flags.failed = 1;
+               msg->hdr.completion_status = (u32)(-response);
+       }
+}
+
+static void
+controlvm_respond_chipset_init(struct controlvm_message_header *msg_hdr,
+                              int response,
+                              enum ultra_chipset_feature features)
+{
+       struct controlvm_message outmsg;
+
+       controlvm_init_response(&outmsg, msg_hdr, response);
+       outmsg.cmd.init_chipset.features = features;
+       if (!visorchannel_signalinsert(controlvm_channel,
+                                      CONTROLVM_QUEUE_REQUEST, &outmsg)) {
+               return;
+       }
+}
+
 static void
 chipset_init(struct controlvm_message *inmsg)
 {
@@ -671,21 +698,6 @@ out_respond:
                controlvm_respond_chipset_init(&inmsg->hdr, rc, features);
 }
 
-static void
-controlvm_init_response(struct controlvm_message *msg,
-                       struct controlvm_message_header *msg_hdr, int response)
-{
-       memset(msg, 0, sizeof(struct controlvm_message));
-       memcpy(&msg->hdr, msg_hdr, sizeof(struct controlvm_message_header));
-       msg->hdr.payload_bytes = 0;
-       msg->hdr.payload_vm_offset = 0;
-       msg->hdr.payload_max_bytes = 0;
-       if (response < 0) {
-               msg->hdr.flags.failed = 1;
-               msg->hdr.completion_status = (u32)(-response);
-       }
-}
-
 static void
 controlvm_respond(struct controlvm_message_header *msg_hdr, int response)
 {
@@ -701,21 +713,6 @@ controlvm_respond(struct controlvm_message_header *msg_hdr, int response)
        }
 }
 
-static void
-controlvm_respond_chipset_init(struct controlvm_message_header *msg_hdr,
-                              int response,
-                              enum ultra_chipset_feature features)
-{
-       struct controlvm_message outmsg;
-
-       controlvm_init_response(&outmsg, msg_hdr, response);
-       outmsg.cmd.init_chipset.features = features;
-       if (!visorchannel_signalinsert(controlvm_channel,
-                                      CONTROLVM_QUEUE_REQUEST, &outmsg)) {
-               return;
-       }
-}
-
 static void controlvm_respond_physdev_changestate(
                struct controlvm_message_header *msg_hdr, int response,
                struct spar_segment_state state)