NFS: fix unsigned comparison in nfs4_create_sec_client
authorBenny Halevy <bhalevy@tonian.com>
Wed, 16 May 2012 08:35:36 +0000 (11:35 +0300)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Wed, 16 May 2012 17:36:50 +0000 (10:36 -0700)
fs/nfs/nfs4namespace.c: In function ‘nfs4_create_sec_client’:
fs/nfs/nfs4namespace.c:171:2: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]

Introduced by commit 72de53ec4bca39c26709122a8f78bfefe7b6bca4
"NFS: Do secinfo as part of lookup"

Signed-off-by: Benny Halevy <bhalevy@tonian.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/nfs4namespace.c

index a7f3dedc4ec7bade9df84ed6f0fc7524507b9c21..3f5519b7c8c835cc1fbc860f9fa29799757685e3 100644 (file)
@@ -168,7 +168,7 @@ struct rpc_clnt *nfs4_create_sec_client(struct rpc_clnt *clnt, struct inode *ino
        rpc_authflavor_t flavor;
 
        flavor = nfs4_negotiate_security(inode, name);
-       if (flavor < 0)
+       if ((int)flavor < 0)
                return ERR_PTR(flavor);
 
        clone = rpc_clone_client(clnt);