Staging: unisys: Use kcalloc instead of kzalloc to allocate array
authorShraddha Barke <shraddha.6596@gmail.com>
Fri, 9 Oct 2015 15:33:28 +0000 (21:03 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Oct 2015 03:49:29 +0000 (20:49 -0700)
The advantage of kcalloc is, that will prevent integer overflows which
could result from the multiplication of number of elements and size and
it is also a bit nicer to read.

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visornic/visornic_main.c

index 85c9fec6549e0a2c5e1fc9e3746bfc575e479839..6db74ded184cdafcd8442ac81605de4cfdd11cd4 100644 (file)
@@ -1797,8 +1797,8 @@ static int visornic_probe(struct visor_device *dev)
                goto cleanup_netdev;
        }
 
-       devdata->rcvbuf = kzalloc(sizeof(struct sk_buff *) *
-                                 devdata->num_rcv_bufs, GFP_KERNEL);
+       devdata->rcvbuf = kcalloc(devdata->num_rcv_bufs,
+                                 sizeof(struct sk_buff *), GFP_KERNEL);
        if (!devdata->rcvbuf) {
                err = -ENOMEM;
                goto cleanup_rcvbuf;