[media] media-entity: enforce check of interface and links creation
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Fri, 4 Sep 2015 18:34:19 +0000 (15:34 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 11 Jan 2016 14:18:59 +0000 (12:18 -0200)
Drivers should check if interfaces and interface links were
created. Add a must_check for them.

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
include/media/media-entity.h

index 3b591d72c70335b70f8e7f8784afc3da2e55be0f..7128d3b0b848526ca2120c22c8dab885851d6928 100644 (file)
@@ -373,14 +373,16 @@ __must_check int media_entity_pipeline_start(struct media_entity *entity,
                                             struct media_pipeline *pipe);
 void media_entity_pipeline_stop(struct media_entity *entity);
 
-struct media_intf_devnode *media_devnode_create(struct media_device *mdev,
-                                               u32 type, u32 flags,
-                                               u32 major, u32 minor,
-                                               gfp_t gfp_flags);
+struct media_intf_devnode *
+__must_check media_devnode_create(struct media_device *mdev,
+                                 u32 type, u32 flags,
+                                 u32 major, u32 minor,
+                                 gfp_t gfp_flags);
 void media_devnode_remove(struct media_intf_devnode *devnode);
-struct media_link *media_create_intf_link(struct media_entity *entity,
-                                           struct media_interface *intf,
-                                           u32 flags);
+struct media_link *
+__must_check media_create_intf_link(struct media_entity *entity,
+                                   struct media_interface *intf,
+                                   u32 flags);
 void __media_remove_intf_link(struct media_link *link);
 void media_remove_intf_link(struct media_link *link);
 void __media_remove_intf_links(struct media_interface *intf);