pnp: fix "add acpi:* modalias entries"
authorKay Sievers <kay.sievers@vrfy.org>
Thu, 21 Aug 2008 13:28:56 +0000 (15:28 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 21 Aug 2008 17:15:39 +0000 (10:15 -0700)
With 22454cb99fc39f2629ad06a7eccb3df312f8830e we added only the
first entry of the device table. We need to loop over the whole
device list.

Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
scripts/mod/file2alias.c

index 4fa1f3ad251340833a3b5d4b094dbc0c05557068..4c9890ec252875500c6c35d388fdd44af9545f34 100644 (file)
@@ -344,14 +344,20 @@ static void do_pnp_device_entry(void *symval, unsigned long size,
                                struct module *mod)
 {
        const unsigned long id_size = sizeof(struct pnp_device_id);
-       const struct pnp_device_id *id = symval;
+       const unsigned int count = (size / id_size)-1;
+       const struct pnp_device_id *devs = symval;
+       unsigned int i;
 
        device_id_check(mod->name, "pnp", size, id_size, symval);
 
-       buf_printf(&mod->dev_table_buf,
-                  "MODULE_ALIAS(\"pnp:d%s*\");\n", id->id);
-       buf_printf(&mod->dev_table_buf,
-                  "MODULE_ALIAS(\"acpi*:%s:*\");\n", id->id);
+       for (i = 0; i < count; i++) {
+               const char *id = (char *)devs[i].id;
+
+               buf_printf(&mod->dev_table_buf,
+                          "MODULE_ALIAS(\"pnp:d%s*\");\n", id);
+               buf_printf(&mod->dev_table_buf,
+                          "MODULE_ALIAS(\"acpi*:%s:*\");\n", id);
+       }
 }
 
 /* looks like: "pnp:dD" for every device of the card */