Apply suggestions from code review

diff --git a/wcfsetup/install/files/lib/system/html/input/node/HtmlInputNodeTextParser.class.php b/wcfsetup/install/files/lib/system/html/input/node/HtmlInputNodeTextParser.class.php
index 371dcef2c6dfb214f6108d4cca92a9887b8d0c5c..071c00690a4a74029bd3895fa7a43d1e46680a21 100644 (file)
--- a/wcfsetup/install/files/lib/system/html/input/node/HtmlInputNodeTextParser.class.php
+++ b/wcfsetup/install/files/lib/system/html/input/node/HtmlInputNodeTextParser.class.php
@@ -420,32 +420,31 @@ class HtmlInputNodeTextParser
      */
     protected function parseURL(\DOMText $text, $value, $allowURL, $allowMedia)
     {
-        static $urlPattern = '';
-        if ($urlPattern === '') {
-            $urlPattern = "#(?i)\b((?:[a-z][\w-]+:(?:/{1,3}|[a-z0-9%])|www\d{0,3}[.]|[a-z0-9.\-]+[.][a-z]{2,4}/)(?:[^\s()<>]+|\(([^\s()<>]+|(\([^\s()<>]+\)))*\))+(?:\(([^\s()<>]+|(\([^\s()<>]+\)))*\)|[^\s`!()\[\]{};:'\".,<>?«»“”‘’]))#iS";
-        }
-
-        return \preg_replace_callback($urlPattern, function ($matches) use ($text, $allowURL, $allowMedia) {
-            $link = $matches[0];
+        return \preg_replace_callback(
+            "#(?i)\b((?:[a-z][\w-]+:(?:/{1,3}|[a-z0-9%])|www\d{0,3}[.]|[a-z0-9.\-]+[.][a-z]{2,4}/)(?:[^\s()<>]+|\(([^\s()<>]+|(\([^\s()<>]+\)))*\))+(?:\(([^\s()<>]+|(\([^\s()<>]+\)))*\)|[^\s`!()\[\]{};:'\".,<>?«»“”‘’]))#iS",
+            function ($matches) use ($text, $allowURL, $allowMedia) {
+                $link = $matches[0];
+
+                if ($allowMedia && BBCodeMediaProvider::isMediaURL($link)) {
+                    $element = $this->htmlInputNodeProcessor->createMetacodeElement($text, 'media', []);
+                    $element->appendChild($element->ownerDocument->createTextNode($link));
+                } elseif ($allowURL) {
+                    // add protocol if necessary
+                    if (!\preg_match('/[a-z]:\/\//si', $link)) {
+                        $link = 'http://' . $link;
+                    }
 
-            if ($allowMedia && BBCodeMediaProvider::isMediaURL($link)) {
-                $element = $this->htmlInputNodeProcessor->createMetacodeElement($text, 'media', []);
-                $element->appendChild($element->ownerDocument->createTextNode($link));
-            } elseif ($allowURL) {
-                // add protocol if necessary
-                if (!\preg_match('/[a-z]:\/\//si', $link)) {
-                    $link = 'http://' . $link;
+                    $element = $text->ownerDocument->createElement('a');
+                    $element->setAttribute('href', $link);
+                    $element->appendChild($element->ownerDocument->createTextNode($link));
+                } else {
+                    return $matches[0];
                 }
 
-                $element = $text->ownerDocument->createElement('a');
-                $element->setAttribute('href', $link);
-                $element->appendChild($element->ownerDocument->createTextNode($link));
-            } else {
-                return $matches[0];
-            }
-
-            return $this->addReplacement($text, $element);
-        }, $value);
+                return $this->addReplacement($text, $element);
+            },
+            $value
+        );
     }
 
     /**