of: overlay: add resolver error prints
authorMichal Suchanek <hramrach@gmail.com>
Sun, 26 Jun 2016 20:11:58 +0000 (22:11 +0200)
committerRob Herring <robh@kernel.org>
Mon, 18 Jul 2016 22:18:36 +0000 (17:18 -0500)
Applying overlay fails silently in case of an error. Add error prints.
Most notably the lack of symbols in the live tree is not reported.

Signed-off-by: Michal Suchanek <hramrach@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/resolver.c

index 741461142984da490bd50bd32d0ada721feed68c..46325d6394cfe4913d07fcfab1f6f5210d89fa9f 100644 (file)
@@ -315,6 +315,11 @@ int of_resolve_phandles(struct device_node *resolve)
        phandle phandle, phandle_delta;
        int err;
 
+       if (!resolve)
+               pr_err("%s: null node\n", __func__);
+       if (resolve && !of_node_check_flag(resolve, OF_DETACHED))
+               pr_err("%s: node %s not detached\n", __func__,
+                        resolve->full_name);
        /* the resolve node must exist, and be detached */
        if (!resolve || !of_node_check_flag(resolve, OF_DETACHED))
                return -EINVAL;
@@ -371,6 +376,7 @@ int of_resolve_phandles(struct device_node *resolve)
 
        /* we need to fixup, but no root symbols... */
        if (!root_sym) {
+               pr_err("%s: no symbols in root of device tree.\n", __func__);
                err = -EINVAL;
                goto out;
        }