X25: Use identifiers for cyclades device to x25 interface
authorandrew hendry <andrew.hendry@gmail.com>
Mon, 19 Apr 2010 13:30:13 +0000 (13:30 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Apr 2010 23:12:50 +0000 (16:12 -0700)
Change magic numbers to identifiers for X25 interface.

Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/cycx_x25.c

index cd8cb95c5bd78920c648b2b47831bd9e086bb701..cf9e15fd8d9106ad31ae2bb303459ac5883b4d79 100644 (file)
@@ -634,11 +634,12 @@ static netdev_tx_t cycx_netdevice_hard_start_xmit(struct sk_buff *skb,
        }
        } else { /* chan->protocol == ETH_P_X25 */
                switch (skb->data[0]) {
-               case 0: break;
-               case 1: /* Connect request */
+               case X25_IFACE_DATA:
+                       break;
+               case X25_IFACE_CONNECT:
                        cycx_x25_chan_connect(dev);
                        goto free_packet;
-               case 2: /* Disconnect request */
+               case X25_IFACE_DISCONNECT:
                        cycx_x25_chan_disconnect(dev);
                        goto free_packet;
                default:
@@ -1406,7 +1407,8 @@ static void cycx_x25_set_chan_state(struct net_device *dev, u8 state)
                        reset_timer(dev);
 
                        if (chan->protocol == ETH_P_X25)
-                               cycx_x25_chan_send_event(dev, 1);
+                               cycx_x25_chan_send_event(dev,
+                                       X25_IFACE_CONNECT);
 
                        break;
                case WAN_CONNECTING:
@@ -1424,7 +1426,8 @@ static void cycx_x25_set_chan_state(struct net_device *dev, u8 state)
                        }
 
                        if (chan->protocol == ETH_P_X25)
-                               cycx_x25_chan_send_event(dev, 2);
+                               cycx_x25_chan_send_event(dev,
+                                       X25_IFACE_DISCONNECT);
 
                        netif_wake_queue(dev);
                        break;