net: mvneta: Improve two size determinations in mvneta_init()
authorMarkus Elfring <elfring@users.sourceforge.net>
Sun, 16 Apr 2017 19:45:38 +0000 (21:45 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Apr 2017 17:55:06 +0000 (13:55 -0400)
Replace the specification of two data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvneta.c

index 652e7ab4b70895c7e2861c02862ca422263885e2..3c4c05b7cc92efabea04019a44c47b4eba503da0 100644 (file)
@@ -4002,8 +4002,7 @@ static int mvneta_init(struct device *dev, struct mvneta_port *pp)
        /* Set port default values */
        mvneta_defaults_set(pp);
 
-       pp->txqs = devm_kcalloc(dev, txq_number, sizeof(struct mvneta_tx_queue),
-                               GFP_KERNEL);
+       pp->txqs = devm_kcalloc(dev, txq_number, sizeof(*pp->txqs), GFP_KERNEL);
        if (!pp->txqs)
                return -ENOMEM;
 
@@ -4015,8 +4014,7 @@ static int mvneta_init(struct device *dev, struct mvneta_port *pp)
                txq->done_pkts_coal = MVNETA_TXDONE_COAL_PKTS;
        }
 
-       pp->rxqs = devm_kcalloc(dev, rxq_number, sizeof(struct mvneta_rx_queue),
-                               GFP_KERNEL);
+       pp->rxqs = devm_kcalloc(dev, rxq_number, sizeof(*pp->rxqs), GFP_KERNEL);
        if (!pp->rxqs)
                return -ENOMEM;