staging: unisys: visorbus: return EAGAIN when empty
authorDavid Kershner <david.kershner@unisys.com>
Mon, 21 Nov 2016 17:15:52 +0000 (12:15 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Nov 2016 09:01:57 +0000 (10:01 +0100)
It really isn't an error when you call visorchannel_signalremove and
there isn't anything in the queue. Just means that the IOSP didn't
process anything since the last time you checked. Just inform the
caller that it is empty by returning -EAGAIN.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/visorchannel.c

index 738830e3be94e527202e094ec3eed9e80e9b24db..f51a7258bef07bcc8898afff28c37fc050b5dc77 100644 (file)
@@ -237,8 +237,9 @@ signalremove_inner(struct visorchannel *channel, u32 queue, void *msg)
        if (error)
                return error;
 
+       /* No signals to remove; have caller try again. */
        if (sig_hdr.head == sig_hdr.tail)
-               return -EIO;    /* no signals to remove */
+               return -EAGAIN;
 
        sig_hdr.tail = (sig_hdr.tail + 1) % sig_hdr.max_slots;