FROMLIST: proc: Add LSM hook checks to /proc/<tid>/timerslack_ns
authorJohn Stultz <john.stultz@linaro.org>
Fri, 15 Jul 2016 00:22:19 +0000 (17:22 -0700)
committerJohn Stultz <john.stultz@linaro.org>
Mon, 25 Jul 2016 21:35:11 +0000 (14:35 -0700)
As requested, this patch checks the existing LSM hooks
task_getscheduler/task_setscheduler when reading or modifying
the task's timerslack value.

Previous versions added new get/settimerslack LSM hooks, but
since they checked the same PROCESS__SET/GETSCHED values as
existing hooks, it was suggested we just use the existing ones.

Cc: Kees Cook <keescook@chromium.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
CC: Arjan van de Ven <arjan@linux.intel.com>
Cc: Oren Laadan <orenl@cellrox.com>
Cc: Ruchi Kandoi <kandoiruchi@google.com>
Cc: Rom Lemarchand <romlem@android.com>
Cc: Todd Kjos <tkjos@google.com>
Cc: Colin Cross <ccross@android.com>
Cc: Nick Kralevich <nnk@google.com>
Cc: Dmitry Shmidt <dimitrysh@google.com>
Cc: Elliott Hughes <enh@google.com>
Cc: James Morris <jmorris@namei.org>
Cc: Android Kernel Team <kernel-team@android.com>
Cc: linux-security-module@vger.kernel.org
Cc: selinux@tycho.nsa.gov
Signed-off-by: John Stultz <john.stultz@linaro.org>
FROMLIST URL: https://lkml.org/lkml/2016/7/21/523
Change-Id: Id157d10e2fe0b85f1be45035a6117358a42af028
(Cherry picked back to common/android-4.4)
Signed-off-by: John Stultz <john.stultz@linaro.org>
fs/proc/base.c

index ee1b021e153eed5f0d8a791f6d8a6ceade6c9656..ac5d2aea63b5281a6c3b487bac93a58b3564a041 100644 (file)
@@ -2265,6 +2265,12 @@ static ssize_t timerslack_ns_write(struct file *file, const char __user *buf,
                goto out;
        }
 
+       err = security_task_setscheduler(p);
+       if (err) {
+               count = err;
+               goto out;
+       }
+
        task_lock(p);
        if (slack_ns == 0)
                p->timer_slack_ns = p->default_timer_slack_ns;
@@ -2293,6 +2299,10 @@ static int timerslack_ns_show(struct seq_file *m, void *v)
                goto out;
        }
 
+       err = security_task_getscheduler(p);
+       if (err)
+               goto out;
+
        task_lock(p);
        seq_printf(m, "%llu\n", p->timer_slack_ns);
        task_unlock(p);