Proper handling of click events for smilies
authorAlexander Ebert <ebert@woltlab.com>
Sat, 27 Jul 2019 20:38:59 +0000 (22:38 +0200)
committerAlexander Ebert <ebert@woltlab.com>
Sat, 27 Jul 2019 20:38:59 +0000 (22:38 +0200)
wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Smiley/Insert.js

index cccd1340a2b13341b9f44f664de594e222e41ee7..00a945eab439b66600f3c4ebed7fb772ea67bee7 100644 (file)
@@ -80,16 +80,14 @@ define(['EventHandler', 'EventKey'], function (EventHandler, EventKey) {
                 * @protected
                 */
                _mousedown: function (event) {
-                       if (!this._container.contains(event.target)) {
-                               return;
-                       }
-                       
-                       event.preventDefault();
-                       
                        // Clicks may occur on a few different elements, but we are only looking for the image.
                        var listItem = event.target.closest('li');
-                       var img = elBySel('img', listItem);
-                       if (img) this._insert(img);
+                       if (this._container.contains(listItem)) {
+                               event.preventDefault();
+                               
+                               var img = elBySel('img', listItem);
+                               if (img) this._insert(img);
+                       }
                },
                
                /**