projects
/
GitHub
/
MotorolaMobilityLLC
/
kernel-slsi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
cbf1f9a
)
IB/rxe: Don't check for null ptr in send()
author
Andrew Boyer
<andrew.boyer@dell.com>
Thu, 22 Dec 2016 13:54:38 +0000
(08:54 -0500)
committer
Doug Ledford
<dledford@redhat.com>
Thu, 22 Dec 2016 16:36:12 +0000
(11:36 -0500)
pkt->qp was already dereferenced earlier in the function.
Fixes Smatch complaint:
drivers/infiniband/sw/rxe/rxe_net.c:458 send()
warn: variable dereferenced before check 'pkt->qp' (see line 441)
Signed-off-by: Andrew Boyer <andrew.boyer@dell.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/sw/rxe/rxe_net.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/infiniband/sw/rxe/rxe_net.c
b/drivers/infiniband/sw/rxe/rxe_net.c
index a576603304f7d5640f68a6f38218b7312351ae14..10ec699834fa3b58f7b158ae29326e4f3874da62 100644
(file)
--- a/
drivers/infiniband/sw/rxe/rxe_net.c
+++ b/
drivers/infiniband/sw/rxe/rxe_net.c
@@
-459,8
+459,7
@@
static int send(struct rxe_dev *rxe, struct rxe_pkt_info *pkt,
return -EAGAIN;
}
- if (pkt->qp)
- atomic_inc(&pkt->qp->skb_out);
+ atomic_inc(&pkt->qp->skb_out);
kfree_skb(skb);
return 0;