can: cc770: Fix use after free in cc770_tx_interrupt()

commit 9ffd7503944ec7c0ef41c3245d1306c221aef2be upstream.

This fixes use after free introduced by the last cc770 patch.

Signed-off-by: Andri Yngvason <andri.yngvason@marel.com>
Fixes: 746201235b3f ("can: cc770: Fix queue stall & dropped RTR reply")
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/net/can/cc770/cc770.c b/drivers/net/can/cc770/cc770.c
index 2743d82d4424d703d047823d4ee278c2b865f435..6da69af103e60d9e26ed30815fc946be56aee224 100644 (file)
--- a/drivers/net/can/cc770/cc770.c
+++ b/drivers/net/can/cc770/cc770.c
@@ -706,13 +706,12 @@ static void cc770_tx_interrupt(struct net_device *dev, unsigned int o)
                return;
        }
 
-       can_put_echo_skb(priv->tx_skb, dev, 0);
-       can_get_echo_skb(dev, 0);
-
        cf = (struct can_frame *)priv->tx_skb->data;
        stats->tx_bytes += cf->can_dlc;
        stats->tx_packets++;
 
+       can_put_echo_skb(priv->tx_skb, dev, 0);
+       can_get_echo_skb(dev, 0);
        priv->tx_skb = NULL;
 
        netif_wake_queue(dev);