mlxsw: fix error return code
authorJulia Lawall <julia.lawall@lip6.fr>
Sun, 23 Aug 2015 00:11:16 +0000 (02:11 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 25 Aug 2015 20:37:31 +0000 (13:37 -0700)
Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/pci.c

index a34f4742aa00c38ffeb57becec36b9b1b467d285..045f98fed476f96f506d75d23c355c595c42c2d4 100644 (file)
@@ -1726,6 +1726,7 @@ static int mlxsw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
                                                mlxsw_pci_dbg_root);
        if (!mlxsw_pci->dbg_dir) {
                dev_err(&pdev->dev, "Failed to create debugfs dir\n");
+               err = -ENOMEM;
                goto err_dbg_create_dir;
        }