netfilter: nf_tables: use RCU-safe list insertion when replacing rules
authorPablo Neira Ayuso <pablo@netfilter.org>
Tue, 10 Jun 2014 08:53:00 +0000 (10:53 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 16 Jun 2014 11:07:29 +0000 (13:07 +0200)
The patch 5e94846 ("netfilter: nf_tables: add insert operation") did
not include RCU-safe list insertion when replacing rules.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c

index 624e083125b93b8755819f868c90307f04cd74b8..ba37c10e5139b6f9573825050d448e574d27cd0f 100644 (file)
@@ -1796,7 +1796,7 @@ static int nf_tables_newrule(struct sock *nlsk, struct sk_buff *skb,
                                goto err2;
                        }
                        nft_rule_disactivate_next(net, old_rule);
-                       list_add_tail(&rule->list, &old_rule->list);
+                       list_add_tail_rcu(&rule->list, &old_rule->list);
                } else {
                        err = -ENOENT;
                        goto err2;