crypto: chcr - Fix Smatch Complaint
authorHarsh Jain <harsh@chelsio.com>
Fri, 27 Jan 2017 10:39:12 +0000 (16:09 +0530)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 3 Feb 2017 10:16:16 +0000 (18:16 +0800)
Initialise variable after null check.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Harsh Jain <harsh@chelsio.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/chelsio/chcr_algo.c [changed mode: 0644->0755]

old mode 100644 (file)
new mode 100755 (executable)
index 21fc04c..41bc7f4
@@ -2456,13 +2456,14 @@ static int chcr_aead_op(struct aead_request *req,
 {
        struct crypto_aead *tfm = crypto_aead_reqtfm(req);
        struct chcr_context *ctx = crypto_aead_ctx(tfm);
-       struct uld_ctx *u_ctx = ULD_CTX(ctx);
+       struct uld_ctx *u_ctx;
        struct sk_buff *skb;
 
-       if (ctx && !ctx->dev) {
+       if (!ctx->dev) {
                pr_err("chcr : %s : No crypto device.\n", __func__);
                return -ENXIO;
        }
+       u_ctx = ULD_CTX(ctx);
        if (cxgb4_is_crypto_q_full(u_ctx->lldi.ports[0],
                                   ctx->tx_channel_id)) {
                if (!(req->base.flags & CRYPTO_TFM_REQ_MAY_BACKLOG))