inet: frags: reorganize struct netns_frags
authorEric Dumazet <edumazet@google.com>
Wed, 10 Oct 2018 19:30:04 +0000 (12:30 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Oct 2018 07:13:25 +0000 (09:13 +0200)
Put the read-mostly fields in a separate cache line
at the beginning of struct netns_frags, to reduce
false sharing noticed in inet_frag_kill()

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit c2615cf5a761b32bf74e85bddc223dfff3d9b9f0)
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/net/inet_frag.h

index dea175f3418a0ef8094c930262329401ab6a2110..f47678d2ccc26a350f5b58fdfecf18dd919571c3 100644 (file)
@@ -4,16 +4,17 @@
 #include <linux/rhashtable.h>
 
 struct netns_frags {
-       struct rhashtable       rhashtable ____cacheline_aligned_in_smp;
-
-       /* Keep atomic mem on separate cachelines in structs that include it */
-       atomic_long_t           mem ____cacheline_aligned_in_smp;
        /* sysctls */
        long                    high_thresh;
        long                    low_thresh;
        int                     timeout;
        int                     max_dist;
        struct inet_frags       *f;
+
+       struct rhashtable       rhashtable ____cacheline_aligned_in_smp;
+
+       /* Keep atomic mem on separate cachelines in structs that include it */
+       atomic_long_t           mem ____cacheline_aligned_in_smp;
 };
 
 /**