Apply changes from review on form builder TypeScript code

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Button.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Button.js
index ff97b3835f4cd44cfe3afbb586da80fab65553af..983f78c5eed464648920f9b48ae4e794c3fb4f9d 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Button.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Button.js
@@ -10,6 +10,7 @@
 define(["require", "exports", "tslib", "./Field"], function (require, exports, tslib_1, Field_1) {
     "use strict";
     Object.defineProperty(exports, "__esModule", { value: true });
+    exports.Button = void 0;
     Field_1 = tslib_1.__importDefault(Field_1);
     class Button extends Field_1.default {
         _getData() {
@@ -20,5 +21,6 @@ define(["require", "exports", "tslib", "./Field"], function (require, exports, t
             return data;
         }
     }
+    exports.Button = Button;
     exports.default = Button;
 });

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Checked.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Checked.js
index 112a4c8a9838fc45b1f6c2be5c499b5c3911f627..267b36e684a9451bd789be5b91baa6456f1e2af1 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Checked.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Checked.js
@@ -15,7 +15,7 @@ define(["require", "exports", "tslib", "./Field", "../../../Core"], function (re
     class Checked extends Field_1.default {
         _getData() {
             return {
-                [this._fieldId]: this._field.checked ? "1" : "0",
+                [this._fieldId]: this._field.checked ? 1 : 0,
             };
         }
     }

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/RadioButton.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/RadioButton.js
index d647b149be17a2255c48bf1835d453c1856665bd..3619d51d2f8e4f92262fa023b7804eb98ea8e87a 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/RadioButton.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/RadioButton.js
@@ -19,6 +19,7 @@ define(["require", "exports", "tslib", "./Field", "../../../Core"], function (re
                     data[this._fieldId] = input.value;
                     return true;
                 }
+                return false;
             });
             return data;
         }

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Tag.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Tag.js
index 4871837882d73d11536d663cfc67067ebcb1e41a..cdbed7e6bf8664e69aee0fec6db83c7ae708202a 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Tag.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Tag.js
@@ -14,9 +14,7 @@ define(["require", "exports", "tslib", "./Field", "../../../Ui/ItemList", "../..
     Core = tslib_1.__importStar(Core);
     class Tag extends Field_1.default {
         _getData() {
-            const values = UiItemList.getValues(this._fieldId).map((item) => {
-                return item.value;
-            });
+            const values = UiItemList.getValues(this._fieldId).map((item) => item.value);
             return {
                 [this._fieldId]: values,
             };

diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/Button.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/Button.ts
index 08deadece7a2b5287f37a4c00917396eade4be92..c88f19846ac437464a06d3f761660e438489242a 100644 (file)
--- a/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/Button.ts
+++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/Button.ts
@@ -11,7 +11,7 @@
 import Field from "./Field";
 import { FormBuilderData } from "../Data";
 
-export default class Button extends Field {
+export class Button extends Field {
   protected _getData(): FormBuilderData {
     const data = {};
 
@@ -22,3 +22,5 @@ export default class Button extends Field {
     return data;
   }
 }
+
+export default Button;

diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/Checked.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/Checked.ts
index 5f5bcedc040d6cd604b2d13c88089529a6304ec3..401052762a1f37749d8be56d76e3a645cd019e31 100644 (file)
--- a/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/Checked.ts
+++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/Checked.ts
@@ -16,7 +16,7 @@ import * as Core from "../../../Core";
 class Checked extends Field {
   protected _getData(): FormBuilderData {
     return {
-      [this._fieldId]: (this._field as HTMLInputElement).checked ? "1" : "0",
+      [this._fieldId]: (this._field as HTMLInputElement).checked ? 1 : 0,
     };
   }
 }

diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/RadioButton.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/RadioButton.ts
index be54ac80911450176c7ccfb53a1bc6cb3a0198e0..cd5ff2b9751ba32fa462a6aedb98ef33016e80fa 100644 (file)
--- a/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/RadioButton.ts
+++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/RadioButton.ts
@@ -23,6 +23,8 @@ class RadioButton extends Field {
         data[this._fieldId] = input.value;
         return true;
       }
+
+      return false;
     });
 
     return data;

diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/Tag.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/Tag.ts
index cee036ec2bad9964dc39ce8e855df9482e21350c..a56b322f4b06720eeabb661dc04dca75c2338bfa 100644 (file)
--- a/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/Tag.ts
+++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/Form/Builder/Field/Tag.ts
@@ -15,9 +15,7 @@ import * as Core from "../../../Core";
 
 class Tag extends Field {
   protected _getData(): FormBuilderData {
-    const values: string[] = UiItemList.getValues(this._fieldId).map((item) => {
-      return item.value;
-    });
+    const values: string[] = UiItemList.getValues(this._fieldId).map((item) => item.value);
 
     return {
       [this._fieldId]: values,