IB/ocrdma: fix bad initialization
authorPan Bian <bianpan2016@163.com>
Sat, 3 Dec 2016 13:10:21 +0000 (21:10 +0800)
committerDoug Ledford <dledford@redhat.com>
Wed, 14 Dec 2016 19:33:48 +0000 (14:33 -0500)
In function ocrdma_mbx_create_ah_tbl(), returns the value of status on
errors. However, because status is initialized with 0, 0 will be
returned even if on error paths. This patch initialize status with
"-ENOMEM".

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188831

Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/ocrdma/ocrdma_hw.c

index 67fc0b6857e185ca4b4a17631741c7cac8a69922..6876a7129e81e055a4b96465a2955917fa8d20a7 100644 (file)
@@ -1642,7 +1642,7 @@ static int ocrdma_build_q_conf(u32 *num_entries, int entry_size,
 static int ocrdma_mbx_create_ah_tbl(struct ocrdma_dev *dev)
 {
        int i;
-       int status = 0;
+       int status = -ENOMEM;
        int max_ah;
        struct ocrdma_create_ah_tbl *cmd;
        struct ocrdma_create_ah_tbl_rsp *rsp;